8000 confidence_ellipse_markup by CarstenSchelp · Pull Request #13950 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

confidence_ellipse_markup #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2019
Merged

confidence_ellipse_markup #13950

merged 2 commits into from
Apr 16, 2019

Conversation

CarstenSchelp
Copy link
Contributor
@CarstenSchelp CarstenSchelp commented Apr 13, 2019 •
edited
Loading

The line "The plotting function itself" should be a heading.

PR Summary

The line "The plotting function itself" should be a heading.
Probably inserting another linefeed above that line will make it render as such.
I hope that this minuscule change will fix it!
Kind regards, Carsten.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@CarstenSchelp
confidence_ellipse.py fix markup fault
6e17525 
The line "The plotting function itself" should be a heading.
Probably inserting another linefeed above that line will make it render as such.
I hope that this minuscule change will fix i!
Kind regards, Carsten.
@CarstenSchelp
Copy link
Contributor Author

Probably I used the wrong entry point for this minuscule change.
Either way, I hope that we can fix this little issue ...

@QuLogic QuLogic changed the base branch from v3.0.2-doc to master April 13, 2019 23:24
@QuLogic
Copy link
Member
QuLogic commented Apr 13, 2019

It did not. I think @timhoffm knows how to fix this kind of thing.

jklymak
jklymak reviewed Apr 14, 2019
View reviewed changes
@timhoffm timhoffm mentioned this pull request Apr 14, 2019
Closed
Move some code between docstring and sphynx-markup
a8039aa 
Thanks to @jklymak for the advice. Moving the imports between the docstring and the sphynx should fix the issue.
@QuLogic QuLogic added this to the v3.1.0 milestone Apr 16, 2019
@QuLogic QuLogic merged commit dd9bcd5 into matplotlib:master Apr 16, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 16, 2019
Backport PR matplotlib#13950: confidence_ellipse_markup
fa8edf4
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 16, 2019
Merged
@CarstenSchelp CarstenSchelp deleted the patch-1 branch April 16, 2019 07:34
dstansby added a commit that referenced this pull request Apr 16, 2019
@dstansby
Merge pull request #13969 from meeseeksmachine/auto-backport-of-pr-13…
ccf1043 
…950-on-v3.1.x

Backport PR #13950 on branch v3.1.x (confidence_ellipse_markup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CarstenSchelp @QuLogic @jklymak @dstansby
0