DOC: Add documentation to Text.set_fontfamily #13949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Apr 14, 2019
timhoffm
reviewed
Apr 14, 2019
lib/matplotlib/text.py
Outdated
| @@ -977,6 +977,11 @@ def set_fontfamily(self, fontname): | |||
| name or a generic font class name. If the latter, the specific font | |||
| names will be looked up in the corresponding rcParams. | |||
|
|
|||
| If a `Text` instance is constructed with `fontfamily=None`, then the | |||
There was a problem hiding this comment.
Suggested change
| If a `Text` instance is constructed with `fontfamily=None`, then the | |
| If a `Text` instance is constructed with ``fontfamily=None``, then the |
timhoffm
approved these changes
Apr 14, 2019
|
Thanks, and congratulations on your first contribution to Matplotlib! Maybe see you back sometime. |
|
@meeseeksdev backport to v3.1.0 |
|
Something went wrong ... Please have a look at my logs. It seem that the branch you are trying to backport to does not exists. |
|
@meeseeksdev backport to v3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 14, 2019
|
Yes, you will definitely see me around...I like to think of this as "giving
back and enhancing" software that I use on a daily basis, so thanks for
reviewing it and hope to see you again soon!
…On Sun, 14 Apr 2019, 11:28 pm Tim Hoffmann, ***@***.***> wrote:
Thanks, and congratulations on your first contribution to Matplotlib!
Maybe see you back sometime.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13949 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMwu8Y_sOyGK3vvEfZuc4WieX0drW7thks5vg2wrgaJpZM4cuLtO>
.
|
timhoffm
added a commit
that referenced
this pull request
Apr 14, 2019
…949-on-v3.1.x Backport PR #13949 on branch v3.1.x (DOC: Add documentation to Text.set_fontfamily)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Fix #13880 by adding documentation to
Text.set_fontfamily()