8000 numpydocify quiverkey. by anntzer · Pull Request #13938 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

numpydocify quiverkey. #13938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2019
Merged

numpydocify quiverkey. #13938

merged 3 commits into from
Apr 20, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 12, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Apr 14, 2019
View reviewed changes
timhoffm
timhoffm reviewed Apr 14, 2019
View reviewed changes
@timhoffm @anntzer
Apply suggestions from code review
51f5c91 
Co-Authored-By: anntzer <anntzer.lee@gmail.com>
@anntzer
Copy link
Contributor Author
anntzer commented Apr 14, 2019

thanks, applied suggestions

timhoffm
timhoffm reviewed Apr 14, 2019
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last bit of nit-picking.

@timhoffm @anntzer
Apply suggestions from code review
32211b8 
Co-Authored-By: anntzer <anntzer.lee@gmail.com>
@anntzer
Copy link
Contributor Author
anntzer commented Apr 14, 2019

done :)

@tacaswell tacaswell merged commit 4975a5e into matplotlib:master Apr 20, 2019
@tacaswell
Copy link
Member

Thank you @anntzer and @timhoffm

@anntzer anntzer deleted the quiverkey_doc branch April 20, 2019 22:22
@QuLogic QuLogic added this to the v3.2.0 milestone Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @QuLogic
0