Better handle deprecated rcParams. #13929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't trigger a deprecation in repr() (e.g., in `$ pydoc matplotlib`). - Don't trigger a deprecation in test_style.py::test_alias.
timhoffm
approved these changes
Apr 11, 2019
QuLogic
reviewed
Apr 12, 2019
| width=80 - indent).split('\n') | ||
| with cbook._suppress_matplotlib_deprecation_warning(): | ||
| repr_split = pprint.pformat(dict(self), indent=1, | ||
| width=80 - indent).split('\n') | ||
| repr_indented = ('\n' + ' ' * indent).join(repr_split) |
There was a problem hiding this comment.
Not exactly related to this PR, but I don't understand why we don't pass indent=indent and skip doing the indent ourselves here.
There was a problem hiding this comment.
Perhaps(?) because the behavior of pprint's indent is less than optimal and would result in
RcParams({ '_internal.classic_mode': False,
'agg.path.chunksize': 0,
'animation.avconv_args': [],
'animation.avconv_path': 'avconv',
...
see also the example at https://docs.python.org/3/library/pprint.html#pprint.PrettyPrinter with indent=4 which clearly shows this (curious?) behavior.
efiring
approved these changes
Apr 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ pydoc matplotlib).PR Summary
PR Checklist