New rcparam to set default axes title location #13802
Conversation
| @@ -294,6 +294,7 @@ | |||
| #axes.grid.axis : both ## which axis the grid should apply to | |||
| #axes.grid.which : major ## gridlines at major, minor or both ticks | |||
| #axes.titlesize : large ## fontsize of the axes title | |||
| #axes.titlelocation : center ## alignment of the title | |||
| #axes.titleweight : normal ## font weight of title | |||
There was a problem hiding this comment.
Maybe a very minor point here: I wouldn't put the location in between two parameters which set some font attributes. Maybe rather put it above size or below weight? Also the comment could mention the three possible values of this parameter.
There was a problem hiding this comment.
I think that's a valid point, I think above size would be a good location
lib/matplotlib/rcsetup.py
Outdated
| @@ -1180,6 +1180,7 @@ def _validate_linestyle(ls): | |||
|
|
|||
| 'axes.titlesize': ['large', validate_fontsize], # fontsize of the | |||
| # axes title | |||
| 'axes.titlelocation': ['center', validate_string], # alignment of axes title | |||
There was a problem hiding this comment.
Maybe the validation should already make sure only valid locations are passed? E.g. adding a
validate_titlelocation = ValidateInStrings('axes.titlelocation', ['left', 'center', 'right'])
and using it as
'axes.titlelocation': ['center', validate_titlelocation], # alignment of axes title
|
In general, this looks good. In addition to the two suggestions above, maybe this should get a test and a what's new notice? |
|
I'll work on the suggestions above and a what's new. In terms of testing, what type of test do you suggest for an implementation like this? For title alignment I think there's a test |
|
I think what we want to test is that the location specified by the rcParams is correctly applied to the title. This may sound trivial, but such tests are still useful. It looks like you can simply amend the |
|
I have modified the existing test by setting the rcParam explicitly in |
|
Not quite sure if this should be So, as a quick vote:
|
PR Summary
UTSC student creating pull request for for CSCD01.
Added new rcparam to set default axes title location requested in #9682.
PR Checklist