8000 Deprecate disable_internet. by anntzer · Pull Request #13783 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate disable_internet. #13783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timhoffm merged 1 commit into from
Jul 27, 2019
Merged

Deprecate disable_internet. #13783

timhoffm merged 1 commit into from
Jul 27, 2019
8000

Conversation

@anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 28, 2019

PR Summary

Goes on top of #13782 (which actually makes this functionality unused).
There are standalone modules doing that and there isn't really a reason for this functionality to be part of mpl.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the remotedata branch 4 times, most recently from 525420c to 12207ba Compare March 29, 2019 11:42
@anntzer anntzer added this to the v3.2.0 milestone Apr 3, 2019
@timhoffm timhoffm merged commit 8d3e817 into matplotlib:master Jul 27, 2019
@anntzer anntzer deleted the remotedata branch July 27, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @QuLogic @timhoffm
0