8000 Reorder the logic of _update_title_position. by anntzer · Pull Request #13756 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Reorder the logic of _update_title_position. #13756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2019
Merged

Reorder the logic of _update_title_position. #13756

merged 1 commit into from
Mar 25, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 25, 2019
  • Replace try... except by explicit check for None (which is the only
    case triggering an exception).
  • Move ymax computation out of the loop.
  • Remove some unused variables (y0) and inline choices.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Reorder the logic of _update_title_position.
5be80e7 
- Replace try... except by explicit check for None (which is the only
  case triggering an exception).
- Move ymax computation out of the loop.
- Remove some unused variables (`y0`) and inline `choices`.
@timhoffm timhoffm added this to the v3.2.0 milestone Mar 25, 2019
@timhoffm
Copy link
Member

Since this is only an internal cleanup, I don‘t think it’s necessary to backport to 3.1.

@timhoffm timhoffm merged commit 4e746b0 into matplotlib:master Mar 25, 2019
@anntzer anntzer deleted the titlepos branch March 25, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @jklymak
0