Deprecate NavigationToolbar2Tk.set_active. #13711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Mar 19, 2019
| @@ -705,6 +705,7 @@ def save_figure(self, *args): | |||
| except Exception as e: | |||
| tkinter.messagebox.showerror("Error saving file", str(e)) | |||
|
|
|||
| @cbook.deprecated("3.1") | |||
| def set_active(self, ind): | |||
| self._ind = ind | |||
| self._active = [self._axes[i] for i in self._ind] | |||
There was a problem hiding this comment.
these attributes appear to be never accessed as well.
It appears to be some vestige of the NavigationToolbar(1) code, with some traces also in the wx examples and currently being deprecated in backend_wx.
d1ec824 to
f85e051
Compare
efiring
approved these changes
May 22, 2019
efiring
added a commit
to efiring/matplotlib
that referenced
this pull request
May 22, 2019
efiring
added a commit
that referenced
this pull request
May 22, 2019
Fix #13711 by importing cbook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be some vestige of the NavigationToolbar(1) code, with
some traces also in the wx examples and currently being deprecated in
backend_wx.
PR Summary
PR Checklist