Put correct version in constrained layout tutorial #13316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelleV
reviewed
Jan 29, 2019
| @@ -45,7 +47,7 @@ | |||
| titles (or sometimes even ticklabels) go outside the figure area, and are thus | |||
| clipped. | |||
|
|
|||
| """ | |||
| """.format(version=matplotlib.__version__) | |||
There was a problem hiding this comment.
How about simply removing this annotation? This will need to be updated once constrained layout is not experimental anyways.
There was a problem hiding this comment.
Not quite sure what you meant; I've just got rid of the version number now, is that okay?
NelleV
approved these changes
Jan 29, 2019
|
This looks good to me! Thanks! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 29, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 29, 2019
dstansby
pushed a commit
that referenced
this pull request
Jan 29, 2019
QuLogic
added a commit
that referenced
this pull request
Feb 3, 2019
…316-on-v3.0.2-doc Backport PR #13316 on branch v3.0.2-doc (Put correct version in constrained layout tutorial)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13311 - we can decide whether to get rid of the message in another PR (my vote would be lets remove it for 3.1)