8000 MAINT removing examples/subplots_axes_and_figures/subplot.py by NelleV · Pull Request #13238 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

MAINT removing examples/subplots_axes_and_figures/subplot.py #13238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MAINT removing examples/subplots_axes_and_figures/subplot.py #13238

wants to merge 1 commit into from

Conversation

NelleV
Copy link
Member
@NelleV NelleV commented Jan 20, 2019

This example is a duplicate of subplot_demo.py, using the pyplot interface instead of the oriented object one

@anntzer
Copy link
Contributor
anntzer commented Jan 20, 2019 •
edited
Loading

There's also https://matplotlib.org/devdocs/gallery/pyplots/pyplot_two_subplots.html#sphx-glr-gallery-pyplots-pyplot-two-subplots-py also using pyplot.
I think it's actually worthwhile to keep one of the two pyplot-based examples (or convert it to individual calls to fig.add_subplot() if we really hate pyplot here, perhaps).

@NelleV
Copy link
Member Author
NelleV commented Jan 20, 2019

Are you asking for a change or just making a statement?

@anntzer
Copy link
Contributor
anntzer commented Jan 20, 2019

I'm suggesting that removing this specific pyplot example may not be best.
Now that I look at it again, I think that if anything I'd rather remove subplot_demo, which is more redundant with subplotS_demo...

@timhoffm
Copy link
Member

I've updated subplots_demo in #13243. With that subplot_demo is really obsolete. Not sure we still additionally need a dedicated pyplot only example as this subplot example.

@anntzer
Copy link
Contributor
anntzer commented Jan 20, 2019 •
edited
Loading

The point (for me) is not so much pyplot-vs-OO, but keeping an example that shows fig.add_subplot(2, 1, 2) / plt.subplot(2, 1, 2) (i.e. adding one subplot at a time).

@NelleV
MAINT removing examples/subplots_axes_and_figures/subplot.py
aa22ad2 
This example is a duplicate of subplot_demo.py, using the pyplot interface instead of the oriented object one
@NelleV
Copy link
Member Author
NelleV commented Jan 22, 2019

@anntzer I'm confident that this is showcased in at least one of our 500 examples. There's really no point of adding examples to the gallery that showcase features that are sufficiently close that there's absolutely no difference between the image generated. It's not how our users use our gallery: they scroll until they find an example with an image that is closely related to what they want to do.

Anyhow, obviously, I disagree with you, as I took the time and effort to open this pull request.

@anntzer
Copy link
Contributor
anntzer commented Jan 22, 2019

My strictly personal belief is that googling/ctrl-f'ing the gallery page is more common.

@dstansby
Copy link
Member
dstansby commented Feb 5, 2019

I'm +/- 0 on this; I think at least the two examples should be merged (the one being deleted at hte moment and the one that's identical apart from using plt.subplots)

@NelleV NelleV closed this Feb 5, 2019
@NelleV NelleV deleted the remove_example branch February 5, 2019 19:27
@NelleV
Copy link
Member Author
NelleV commented Feb 5, 2019

I've closed this PR: if this is not a clear merge, I don't want to spend more time on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NelleV @anntzer @timhoffm @dstansby
0