8000 Broadcast 'orientations' arg to Sankey.add. by anntzer · Pull Request #13213 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Broadcast 'orientations' arg to Sankey.add. #13213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

Broadcast 'orientations' arg to Sankey.add. #13213

merged 1 commit into from
Jan 19, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 17, 2019

PR Summary

Closes the issue reported by the OP in #13184, but not #13184 (comment).

I know there's no tests, and am not volunteering to write them. (But you can manually check that this fixes the OP's issues.)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Jan 17, 2019
Merged
6 tasks
QuLogic
QuLogic reviewed Jan 18, 2019
View reviewed changes
@anntzer
Copy link
Contributor Author
anntzer commented Jan 18, 2019

both comments handled, thanks for the review.

< 8000 a class="avatar avatar-user" style="width:20px;height:20px;" data-test-selector="commits-avatar-stack-avatar-link" data-hovercard-type="user" data-hovercard-url="/users/anntzer/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/anntzer"> @anntzer
Broadcast 'orientations' arg to Sankey.add.
bdacdda
@anntzer
Copy link
Contributor Author
anntzer commented Jan 18, 2019

Actually I removed the change to the docstring (and edited the commit message accordingly) in favor of doing that change in #13217.

@anntzer anntzer changed the title Broadcast 'orientations' arg to Sankey.add and fix its doc. Broadcast 'orientations' arg to Sankey.add. Jan 18, 2019
@QuLogic QuLogic added this to the v3.1 milestone Jan 19, 2019
@QuLogic QuLogic merged commit 0dac001 into matplotlib:master Jan 19, 2019
@anntzer anntzer deleted the sankey branch January 19, 2019 00:20
@colinmorris colinmorris mentioned this pull request Jan 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
0