8000 Remove cairo-based backends from backend fallback. by anntzer · Pull Request #13189 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove cairo-based backends from backend fallback. #13189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

Remove cairo-based backends from backend fallback. #13189

merged 1 commit into from
Jan 17, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 15, 2019

They would never be selected by the fallback machinery anyways.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member
jklymak commented Jan 15, 2019

Do we know why qt tests are failing on Travis?

@jklymak
Copy link
Member
jklymak commented Jan 15, 2019

I guess I don't understand why they would never be selected?

@anntzer
Copy link
Contributor Author
anntzer commented Jan 15, 2019 •
edited
Loading

Because if gtk3cairo imports successfully that just means that PyGObject and PyCairo import successfully; but then gtk3agg (which has the same dependencies, and uses the same interactive framework) would have also imported successfully.
Likewise Agg always imports successfully (if it doesn't something is wrong with the build), so we'll never actually try using cairo instead.
Dunno what's happening with qt.

jklymak
jklymak reviewed Jan 15, 2019
View reviewed changes
jklymak
jklymak reviewed Jan 15, 2019
View reviewed changes
@anntzer
Copy link
Contributor Author
anntzer commented Jan 15, 2019

done x2

timhoffm
timhoffm reviewed Jan 16, 2019
View reviewed changes
QuLogic
QuLogic reviewed Jan 16, 2019
View reviewed changes
@anntzer
Remove cairo-based backends from backend fallback.
d026ed2 
They would never be selected by the fallback machinery anyways.
@jklymak jklymak merged commit f7da452 into matplotlib:master Jan 17, 2019
@anntzer anntzer deleted the no-cairo-fallback branch January 17, 2019 20:53
@tacaswell tacaswell added this to the v3.1 milestone Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @jklymak @QuLogic @timhoffm @tacaswell
0