8000 Let ffmpeg report errors. by anntzer · Pull Request #13155 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Let ffmpeg report errors. #13155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2019
Merged

Let ffmpeg report errors. #13155

merged 1 commit into from
Jan 11, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 11, 2019

at -loglevel errors, one gets for example the error messages for
non-existent directories ("/foo/bar/baz.mp4: no such file or directory"),
which get then picked up by Matplotlib's logging.

Helps with #12769 (comment).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Let ffmpeg report errors.
2b17953 
at -loglevel errors, one gets for example the error messages for
non-existent directories ("/foo/bar/baz.mp4: no such file or directory"),
which get then picked up by Matplotlib's logging.
dstansby
dstansby approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@dstansby dstansby added this to the v3.1 milestone Jan 11, 2019
@anntzer anntzer mentioned this pull request Jan 11, 2019
Merged
6 tasks
@jklymak jklymak merged commit 6a6f21c into matplotlib:master Jan 11, 2019
@anntzer anntzer deleted the ffmpeg-loglevel branch January 12, 2019 10:57
@timhoffm timhoffm mentioned this pull request Jan 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @dstansby
0