Improve margins in formlayout #12885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70777b1 to
ea0efd9
Compare
anntzer
approved these changes
Nov 26, 2018
6 tasks
ea0efd9 to
4c35cf4
Compare
jklymak
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The formlayout has some extra margins in some places. This happens when nesting widgets into a container widget with a layout, which by default has a margin. If you then layout the (transparent) container together with regular widgets. The margin of the container widget insets its content compared to other widgets in the outer layout. This results in extra large margins and edges not being aligned.
This PR removes the extra margins to give a more homogeneous look:
before:
after:
