8000 Cleanup collections docs. by anntzer · Pull Request #12852 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup collections docs. #12852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2018
Merged

Cleanup collections docs. #12852

merged 1 commit into from
Nov 29, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 20, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 20, 2018 8000
timhoffm
timhoffm approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the docstrings an still be improved. But this is already an incremental improvement.

jklymak
jklymak reviewed Nov 20, 2018
View reviewed changes
lib/matplotlib/collections.py Outdated
xs = self.convert_xunits(offsets[:, 0])
ys = self.convert_yunits(offsets[:, 1])
offsets = np.column_stack([xs, ys])
xs = self.convert_xunits(offsets[:, 0])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure you can get rid of this check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought yes (it's not a big deal to convert some zero-sized arrays anyways) but then decided against checking that it doesn't cause any problem, so reverted the removal of the check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - not saying that I think there is a problem, except, someone put the check in at some point for some reason.

@jklymak jklymak merged commit 64f0309 into matplotlib:master Nov 29, 2018
@anntzer anntzer 72BD deleted the collectiondocs branch November 29, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
0