10000 Reword some colorbar docs. by anntzer · Pull Request #12799 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Reword some colorbar docs. #12799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2018
Merged

Reword some colorbar docs. #12799

merged 1 commit into from
Nov 16, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Nov 12, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 12, 2018
timhoffm
timhoffm reviewed Nov 12, 2018
View reviewed changes
lib/matplotlib/colorbar.py Outdated
The `~matplotlib.cm.ScalarMappable` (i.e., `~matplotlib.image.Image`,
`~matplotlib.contour.ContourSet`, etc.) to which the colorbar
applies. This argument is mandatory for the Figure method
`~matplotlib.figure.Figure.colorbar` but optional for the pyplot function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use .Figure.colorbar and .pyplot.colorbar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ImportanceOfBeingErnest ImportanceOfBeingErnest merged commit 56243e9 into matplotlib:master Nov 16, 2018
@anntzer anntzer deleted the colorbar-docs branch November 16, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @ImportanceOfBeingErnest
0