Use the builtin GTK3 FileChooser rather than our custom subclass. #12748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Nov 6, 2018
| dialog.set_current_name( | ||
| str(Path(dialog.get_current_name()).with_suffix("." + fmt))) | ||
|
|
||
| dialog.set_current_folder(rcParams["savefig.directory"]) |
There was a problem hiding this comment.
Current recommendations are to not even call this.
There was a problem hiding this comment.
I know, but that'd mean not respecting the documented rcParam...
e576f59 to
d87742a
Compare
QuLogic
approved these changes
Nov 16, 2018
|
Seems you have flake8 issues. |
d87742a to
6257170
Compare
|
should be fixed now |
6257170 to
b27dcf2
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 27, 2019
… than our custom subclass.
QuLogic
added a commit
that referenced
this pull request
Feb 28, 2019
…748-on-v3.1.x Backport PR #12748 on branch v3.1.x (Use the builtin GTK3 FileChooser rather than our custom subclass.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist