DOC: constrained layout guide (fix: Spacing with colorbars) #12740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 4, 2018
…cing with colorbars)
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 4, 2018
…cing with colorbars)
timhoffm
pushed a commit
that referenced
this pull request
Nov 4, 2018
QuLogic
added a commit
that referenced
this pull request
Nov 5, 2018
…740-on-v3.0.0-doc Backport PR #12740 on branch v3.0.0-doc (DOC: constrained layout guide (fix: Spacing with colorbars))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixed a line in the 'constrained layout guide' that appeared to be slightly misleading. The guide says
"Colorbars still RESPECT the w_pad and h_pad values" and then goes on to show in the next block that
w_pad,h_padcan be overridden by setting a non-zero value for the pad kwarg when callingfig.colorbar.Also fixed an incorrect mappable being passed to
fig.colorbar.PR Checklist
[ ] Has Pytest style unit tests[ ] New features are documented, with examples if plot related[ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)[ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way