8000 FIX: add setter for hold to un-break basemap by tacaswell · Pull Request #12670 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: add setter for hold to un-break basemap #12670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

FIX: add setter for hold to un-break basemap #12670

merged 1 commit into from
Nov 5, 2018

Conversation

tacaswell
Copy link
Member

closes #12669
closes matplotlib/basemap#435

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.0.x milestone Oct 29, 2018
efiring
efiring approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member
@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that should do it. It might be good to add a comment explaining why _hold is here, and providing a target date for when it can be removed.

@WeatherGod
Copy link
Member

agreed that a comment explaining the plan for this property would be useful, or at least a link to this PR. Speaking of which, what will be the plan? When will this get removed?

@tacaswell
Copy link
Member Author

I would like to remove this for real in 3.1

@dopplershift
Copy link
Contributor

I promise we’ll have a release of CartoPy by then. 😭

@jklymak jklymak merged commit a5901fa into matplotlib:master Nov 5, 2018
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 5, 2018
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 5, 2018
@jklymak
Backport PR matplotlib#12670: FIX: add setter for hold to un-break ba…
92196ee 
…semap
@tacaswell
Copy link
Member Author

Well, I just got to pushing the comments :-p

oh well.

timhoffm pushed a commit that referenced this pull request Nov 5, 2018
@meeseeksmachine @timhoffm
Backport PR #12670: FIX: add setter for hold to un-break basemap (#12751
6224e57 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@WeatherGod WeatherGod WeatherGod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging this pull request may close these issues.

fixing _hold on cartopy broke basemap AttributeError: can't set attribute ax._hold = self._tmp_hold
5 participants
@tacaswell @WeatherGod @dopplershift @efiring @jklymak
0