Fix issue with PyPy on macOS #12629
Fix issue with PyPy on macOS #12629
Conversation
|
A little background, copied from the PyPy issue:
PyPy uses a pure-python The relevant code path in tkinter (EnableEventHook and DisableEventHook) is commented out on PyPy. Other platforms perform properly without the hook, I do not know why the MacOS platform uses it on matplotlib. |
|
My guess is they were needed at one point to allow the tkinter event loop and the REPL event loop to play nicely. But then why were they MacOS only, unless at one point python vendored a broken version of tk on that platform? Maybe someone with the oldest python and MacOS matplotlib supports could verify the terminal and the canvas are both responsive after removing the callback |
|
Ok away from computer but maybe we should merge this as fixing pypy and then open the rest as a separate issue. |
|
@mdehoon, could you comment? |
|
This is very tricky stuff; the backend may seem to work fine but you may notice problems later. |
|
Thanks @mdehoon. I checked and we definitely need these hooks for the non pypy work. |
This PR fixes the issue with
PyOS_InputHookvariable that is not defined in PyPy implementation:p.s.
The corresponding issue in PyPy bug tracking is https://bitbucket.org/pypy/pypy/issues/2327