8000 FIX: over-ride 'copy' on RcParams by tacaswell · Pull Request #12604 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

FIX: over-ride 'copy' on RcParams #12604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

FIX: over-ride 'copy' on RcParams #12604

merged 1 commit into from
Oct 23, 2018

Conversation

tacaswell
Copy link
Member

This is due to a fix on upstream
cpython (
python/cpython@d45a961
) which fixed the copy behavior to fall back to the sub-class's
__getitem__ which seems correct, but we were relying on it not
correctly hitting our custom __getitem__.

closes #12601

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell
FIX: over-ride 'copy' on RcParams
ae005f3 
This is due to a fix on upstream
cpython (
python/cpython@d45a961
) which fixed the copy behavior to fall back to the sub-class's
`__getitem__` which seems correct, but we were relying on it _not_
correctly hitting our custom `__getitem__`.

closes matplotlib#12601
@tacaswell tacaswell added this to the v3.0.x milestone Oct 23, 2018
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 23, 2018
@tacaswell
Copy link
Member Author

If this fixes things, I am inclined to merge this and tag 3.0.1 asap and do 3.0.2 on schedule for Nov 3.

@ArchangeGabriel
Copy link
Contributor

I’m currently testing your change. This should indeed make a 3.0.1 ASAP since 3.0.0 as released is now broken.

@ArchangeGabriel
Copy link
Contributor

The import error is indeed fixed, test suite now running on my side.

@QuLogic
Copy link
Member
QuLogic commented Oct 23, 2018

Travis is fixed, but we are somehow hitting #12578 again (though I have no idea how it was 'fixed' either.)

@tacaswell
Copy link
Member Author

restarted mac to see if just got unlucky with caches.

@tacaswell
Copy link
Member Author

I am going to self-merge this with just @dopplershift 's approval and the py3.7 travis being fixed.

@tacaswell tacaswell merged commit 1b0d3aa into matplotlib:v3.0.x Oct 23, 2018
@tacaswell tacaswell deleted the fix_371_import branch October 23, 2018 23:39
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Oct 25, 2018
Closed
@anntzer anntzer mentioned this pull request Oct 27, 2018
Closed
@WeatherGod WeatherGod mentioned this pull request Jul 11, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @ArchangeGabriel @QuLogic @dopplershift
0