8000 Add matplotlib.testing to the documentation by timhoffm · Pull Request #12560 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Add matplotlib.testing to the documentation #12560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Oct 18, 2018

PR Summary

The testing module was not included in the docs. While it may not be useful for the day-to-day user, we should still publish the testing docs because it's part of the library.

Not quite sure, if these do only target matplotlib developers or if other libraries can use that code too to test their matplotlib-generated plots. Improved descriptions would be nice as well, but that's for another PR.

:show-inheritance:


:mod:`matplotlib.testing.determinism`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module exposes literally no public API and is really just a helper for matplotlib.tests.test_backend_{pdf,ps,svg}. It should be renamed to something like matplotlib.tests._test_determinism_helpers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've excluded it from the docs for now. It does not provide docstrings anyway. This makes it easier to rename. But that's for another PR (including a discussion if we need a deprecation first).

@timhoffm
Copy link
Member Author

This does not doc-build because importing conftest.py fails with an ImportError on pytest.

What should we do?

  • Exclude conftest from the documentation.
  • Add pytest to the doc requirements.
  • Prevent the error using autodoc_mock_imports

@timhoffm
Copy link
Member Author

I've now not included conftest.py in the testing docs. While technically it's a submodule, even test writers would not import it. The only thing notable would be the pd fixture, but I'm leaving it out for now to get this passing.

@timhoffm timhoffm added this to the v3.1 milestone Nov 4, 2018
@anntzer
Copy link
Contributor
anntzer commented Nov 16, 2018

the docs don't appear in the circleci build?

@timhoffm
Copy link
Member Author

No clue why CircleCI does not run on this.

I've built the docs locally and they look fine.

@anntzer
Copy link
Contributor
anntzer commented Nov 17, 2018

Looks reasonable then.

@anntzer anntzer merged commit f075b1b into matplotlib:master Nov 17, 2018
@timhoffm timhoffm deleted the doc-testing branch November 17, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0