10000 Throw ValueError when irregularly gridded data is passed to streamplot. by anntzer · Pull Request #12474 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Throw ValueError when irregularly gridded data is passed to streamplot. #12474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

Throw ValueError when irregularly gridded data is passed to streamplot. #12474

merged 1 commit into from
Oct 10, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 10, 2018

... instead of silently generating an incorrect streamplot.

Temporary fix for #12025 (comment) (until someone implements streamplot for irregularly gridded data).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Oct 10, 2018
dstansby
dstansby reviewed Oct 10, 2018
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems reasonable to me if CI passes. Maybe worth adding a test with a non-uniform grid just to make sure the error is raised, but not going to block on that.

@anntzer
Copy link
Contributor Author
anntzer commented Oct 10, 2018

Feel free to push a test.

@anntzer
Throw ValueError when irregularly gridded data is passed to streamplot.
bd643bd 
... instead of silently generating an incorrect streamplot.
@anntzer anntzer force-pushed the streamplot-irregular branch from 4dc035d to bd643bd Compare October 10, 2018 13:24
@dstansby
Copy link
Member

Test failure is un-related

@dstansby dstansby merged commit eecd930 into matplotlib:master Oct 10, 2018
@anntzer anntzer deleted the streamplot-irregular branch October 10, 2018 22:11
Chilipp added a commit to psyplot/psy-simple that referenced this pull request May 26, 2019
@Chilipp
rescale x and y for streamplot (if necessary)
a3abe8f 
see matplotlib/matplotlib#12474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
API: argument checking
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dstansby @jklymak
0