8000 Replace axes_grid by axes_grid1 in test by ImportanceOfBeingErnest · Pull Request #12360 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Replace axes_grid by axes_grid1 in test #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2018
Merged

Replace axes_grid by axes_grid1 in test #12360

merged 1 commit into from
Oct 6, 2018

Conversation

ImportanceOfBeingErnest
Copy link
Member
@ImportanceOfBeingErnest ImportanceOfBeingErnest commented Oct 1, 2018 •
edited
Loading

PR Summary

Replace axes_grid by axes_grid1 in test to suppress warning

/home/travis/build/matplotlib/matplotlib/lib/mpl_toolkits/tests/test_axisartist_grid_helper_curvelinear.py:10: MatplotlibDeprecationWarning: 
The mpl_toolkits.axes_grid module was deprecated in Matplotlib 2.1 and will be removed two minor releases later. Use mpl_toolkits.axes_grid1 and mpl_toolkits.axisartist provies the same functionality instead.
  from mpl_toolkits.axes_grid.parasite_axes import ParasiteAxesAuxTrans, \

The change in the warning message may look a bit strange, this is because the alternative argument gets embedded into "Use " + alternative + " instead."`. So the new message now reads

The mpl_toolkits.axes_grid module was deprecated in Matplotlib 2.1 and will be removed two minor releases later. Use mpl_toolkits.axes_grid1 and mpl_toolkits.axisartist, which provide the same functionality instead.

PR Checklist

  • Is Pytest style unit test
  • Code is Flake 8 compliant

@ImportanceOfBeingErnest ImportanceOfBeingErnest added this to the v3.0.x milestone Oct 1, 2018
@ImportanceOfBeingErnest ImportanceOfBeingErnest changed the title Replace axis_grid by axis_grid1 in test Replace axes_grid by axes_grid1 in test Oct 1, 2018
anntzer
anntzer previously approved these changes Oct 1, 2018
View reviewed changes
timhoffm
timhoffm previously approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just waiting for CI.

Bonus points if you fix the typo in the warning:

Use mpl_toolkits.axes_grid1 and mpl_toolkits.axisartist provies ...

@ImportanceOfBeingErnest
Copy link
Member Author

@anntzer @timhoffm I think you can stale your reviews... judging from test failures this goes deeper than anticipated.

@timhoffm timhoffm dismissed their stale review October 1, 2018 20:41

CI breaking

@ImportanceOfBeingErnest ImportanceOfBeingErnest force-pushed the removewarning-for-axisgridtest branch from c836855 to 7a048f5 Compare October 1, 2018 21:21
@ImportanceOfBeingErnest ImportanceOfBeingErnest force-pushed the removewarning-for-axisgridtest branch from 7a048f5 to 23b8958 Compare October 1, 2018 21:36
@ImportanceOfBeingErnest
Copy link
Member Author

Now it should be correct. There are unfortunately two different versions of SubplotHost around (probably due to the separation into the axisartist and axes_grid1 modules) and using the wrong one caused some hickups.

The remaining test failures are unrelated to this PR, they do occur in other PRs' tests as well.

@dstansby dstansby merged commit a047d38 into matplotlib:master Oct 6, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 6, 2018
@dstansby
Backport PR matplotlib#12360: Replace axes_grid by axes_grid1 in test
830ffe1
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 6, 2018
Merged
QuLogic added a commit that referenced this pull request Oct 11, 2018
@QuLogic
Merge pull request #12421 from meeseeksmachine/auto-backport-of-pr-12…
e70895b 
…360-on-v3.0.x

Backport PR #12360 on branch v3.0.x (Replace axes_grid by axes_grid1 in test)
@ImportanceOfBeingErnest ImportanceOfBeingErnest deleted the removewarning-for-axisgridtest branch February 17, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

@anntzer anntzer anntzer left review comments

@timhoffm timhoffm timhoffm left review comments

Assignees
No one assigned
Labels
topic: mpl_toolkit topic: testing
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ImportanceOfBeingErnest @anntzer @jklymak @timhoffm @dstansby
0