BUG: Fix typo in view_limits() for MultipleLocator #12313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Sep 27, 2018
|
Circle failures are unrelated. |
tacaswell
approved these changes
Sep 27, 2018
|
Travis error is persistent, but seems to be unrelated to this as well. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 27, 2018
jklymak
added a commit
that referenced
this pull request
Sep 28, 2018
…313-on-v3.0.x Backport PR #12313 on branch v3.0.x (BUG: Fix typo in view_limits() for MultipleLocator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes (what looks to be) a copy/paste error in
MultipleLocator. Apparently, we had no tests for this code path. Before this fix, callingview_limits()on an instance ofMultipleLocator(when using'round_numbers'foraxes.autolimit_mode) would give:../../../virtualenv/python3.6.3/lib/python3.6/site-packages/matplotlib/__init__.py:1785: in inner return func(ax, *args, **kwargs) ../../../virtualenv/python3.6.3/lib/python3.6/site-packages/matplotlib/axes/_axes.py:4876: in barbs self.autoscale_view() ../../../virtualenv/python3.6.3/lib/python3.6/site-packages/matplotlib/axes/_base.py:2478: in autoscale_view 'minposx', self.xaxis, self._xmargin, x_stickies, self.set_xbound) ../../../virtualenv/python3.6.3/lib/python3.6/site-packages/matplotlib/axes/_base.py:2472: in handle_single_axis x0, x1 = locator.view_limits(x0, x1) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <matplotlib.ticker.MultipleLocator object at 0x7f98ab3c47f0> dmin = -20.0, dmax = 21.89385499011344 def view_limits(self, dmin, dmax): """ Set the view limits to the nearest multiples of base that contain the data. """ if rcParams['axes.autolimit_mode'] == 'round_numbers': vmin = self._edge.le(dmin) * self._edge.step > vmax = self._base.ge(dmax) * self._edge.step E AttributeError: 'MultipleLocator' object has no attribute '_base' ../../../virtualenv/python3.6.3/lib/python3.6/site-packages/matplotlib/ticker.py:1745: AttributeErrorPR Checklist