8000 Clarify missing-property error message. by anntzer · Pull Request #12307 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Clarify missing-property error message. #12307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 27, 2018

... by including the type of the offending object.

The error message is modelled like CPython's normal AttributeError
message ('foo' object has no attribute 'bar').

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The error message is modelled like CPython's normal AttributeError
message ('foo' object has no attribute 'bar').
@anntzer anntzer added this to the v3.1 milestone Sep 27, 2018
@dstansby dstansby merged commit 1c55a25 into matplotlib:master Sep 27, 2018
@anntzer anntzer deleted the property-missing-message branch September 27, 2018 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0