Simplify empty-rasterized pdf test. #12262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is about saving empty rasterized artists, not about PdfPages. This makes the test compatible with mplcairo, which doesn't support PdfPages.
dstansby
approved these changes
Sep 25, 2018
| @@ -234,9 +234,8 @@ def test_failing_latex(tmpdir): | |||
| plt.savefig(path) | |||
|
|
|||
|
|
|||
| def test_empty_rasterised(): | |||
| def test_empty_rasterized(): | |||
There was a problem hiding this comment.
I resent changing rasterised to rasterized 😉
There was a problem hiding this comment.
I knew this was coming, but it's the name of the property (finally a good use for aliases? :p)
QuLogic
approved these changes
Sep 25, 2018
|
Wait, why the milestone change? |
|
I didn't see why this needs to be backported to |
|
@meeseeksdev backport to v3.0.x It fixes running tests against mplcairo. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 25, 2018
QuLogic
added a commit
that referenced
this pull request
Sep 26, 2018
…262-on-v3.0.x Backport PR #12262 on branch v3.0.x (Simplify empty-rasterized pdf test.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is about saving empty rasterized artists, not about PdfPages.
This makes the test compatible with mplcairo, which doesn't support
PdfPages.
PR Summary
PR Checklist