Make boilerplate-generated pyplot.py flake8 compliant #12236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/boilerplate.py
Outdated
| # Autogenerated by boilerplate.py. Do not edit as changes will be lost.""" | ||
|
|
||
| CMAPPABLE_TEMPLATE = AUTOGEN_MSG + """ | ||
| CMAPPABLE_TEMPLATE = AUTOGEN_MSG + """ |
There was a problem hiding this comment.
Why'd we pick up a space here?
4abab3d to
f8f8b2b
Compare
tacaswell
approved these changes
Sep 23, 2018
dopplershift
approved these changes
Sep 23, 2018
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
timhoffm
pushed a commit
to timhoffm/matplotlib
that referenced
this pull request
Sep 23, 2018
timhoffm
pushed a commit
to timhoffm/matplotlib
that referenced
this pull request
Sep 24, 2018
dstansby
added a commit
that referenced
this pull request
Sep 24, 2018
…v3.0.x Backport PR #12236 on branch v3.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This does two things:
# noqato lines likeif isinstance(__ret, cm.ScalarMappable): sci(__ret).flake 8 complains that this should be wrapped (E701). However that's cumbersome to get a correct indentation. Since these are just 5 cases and it's in autogenerated code, which likely nobody will read anyway, I prefer the explicit exclusion of these lines compared to deactivating E701 for the whole file.
PR Checklist