Fix Agg extent calculations for empty draws #12117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test? |
|
👍 done, and checked that it fails on master without this PR |
|
Great! Thanks @dstansby ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 15, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 15, 2018
dstansby
added a commit
that referenced
this pull request
Sep 15, 2018
…117-on-v3.0.x Backport PR #12117 on branch v3.0.x (Fix Agg extent calculations for empty draws)
dstansby
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 16, 2018
dstansby
added a commit
that referenced
this pull request
Sep 16, 2018
…117-on-v2.2.x Backport PR #12117 on branch v2.2.x (Fix Agg extent calculations for empty draws)
QuLogic
reviewed
Sep 18, 2018
| r.y1 = std::max(0, r.y1); | ||
| r.x2 = std::min(r.x2 + 1, (int)width); | ||
| r.y2 = std::min(r.y2 + 1, (int)height); | ||
| if (r.x1 == width && r.x2 == 0) { |
There was a problem hiding this comment.
This causes a warning now:
src/_backend_agg.cpp: In member function ‘agg::rect_i RendererAgg::get_content_extents()’:
src/_backend_agg.cpp:204:14: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
if (r.x1 == width && r.x2 == 0) {
~~~~~^~~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12003. Putting this on 2.2.4, since it fixes plotting rasterised .pdf files with numpy 1.15.