8000 Small refactor/simplification. by anntzer · Pull Request #12061 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Small refactor/simplification. #12061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Small refactor/simplification. #12061

merged 1 commit into from
Sep 7, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 7, 2018

not much to it.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

8000

del _get_left, _get_right, _get_bottom, _get_top
_get_func_map = {
"left": lambda self, axes_bbox: axes_bbox.xmin - self.xmin,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem with pickling of lambda functions recently. Is is ensured that the GetExtentHelper never needs to be pickled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to not store the lambda on the instance. Storing lambdas at the classlevel is fine re: pickling.

@phobson phobson merged commit 412ad7c into matplotlib:master Sep 7, 2018
@anntzer anntzer deleted the refactor branch September 7, 2018 17:49
@QuLogic QuLogic added this to the v3.1 milestone Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0