8000 Make HTMLWriter constructor a bit more strict. by anntzer · Pull Request #12046 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Make HTMLWriter constructor a bit more strict. #12046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2018
Merged

Make HTMLWriter constructor a bit more strict. #12046

merged 1 commit into from
Sep 6, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 6, 2018

There isn't really a reason to be lenient regarding invalid values for
the default_mode arg.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Make HTMLWriter constructor a bit more strict.
ce95439 
There isn't really a reason to be lenient regarding invalid values for
the default_mode arg.
@dopplershift dopplershift merged commit ef2cf8c into matplotlib:master Sep 6, 2018
@anntzer anntzer deleted the htmlwriter branch September 6, 2018 21:00
@QuLogic QuLogic added this to the v3.1 milestone Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @timhoffm @QuLogic
0