8000 Fix 999.9... edge case in ticker.EngFormatter for negative numbers by Lewn · Pull Request #12045 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix 999.9... edge case in ticker.EngFormatter for negative numbers #12045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 7, 2018
Merged

Fix 999.9... edge case in ticker.EngFormatter for negative numbers #12045

merged 4 commits into from
Sep 7, 2018

Conversation

Lewn
Copy link
Contributor
@Lewn Lewn commented Sep 6, 2018 •
edited
Loading

PR Summary

When using ticker.EngFormatter, a -999.999 value will be displayed as -1000 instead of -1k. The edge case detection for the positive numbers is now extended to the negative numbers.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer requested a review from afvincent September 6, 2018 16:41
jklymak
jklymak reviewed Sep 6, 2018
View reviewed changes
timhoffm
timhoffm reviewed Sep 6, 2018
View reviewed changes
@NelleV NelleV merged commit 0753e59 into matplotlib:master Sep 7, 2018
@NelleV
Copy link
Member
NelleV commented Sep 7, 2018

Thanks @Lewn !

@QuLogic QuLogic modified the milestones: v3.0, v3.1 Sep 7, 2018
@Lewn Lewn deleted the patch-1 branch September 10, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@timhoffm timhoffm timhoffm approved these changes

@afvincent afvincent Awaiting requested review from afvincent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Lewn @NelleV @jklymak @timhoffm @QuLogic
0