8000 Deprecate get_py2exe_datafiles. by anntzer · Pull Request #12043 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Deprecate get_py2exe_datafiles. #12043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2018
Merged

Deprecate get_py2exe_datafiles. #12043

merged 1 commit into from
Sep 6, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 6, 2018

py2exe never supported even Py3.5 (the oldest python Matplotlib
supports) so I'll just assume it's dead...

Deprecate support for it.

(see https://stackoverflow.com/questions/32963057/is-there-a-py2exe-version-thats-compatible-with-python-3-5, https://sourceforge.net/p/py2exe/svn/765/log/?path=/trunk/py2exe-3 (lack of updates since 2014), and I tried setting it up too :p))

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
 

py2exe never supported even Py3.5 (the oldest python Matplotlib
supports) so I'll just assume it's dead...
@anntzer anntzer added this to the v3.1 milestone Sep 6, 2018
@phobson
Copy link
Member
phobson commented Sep 6, 2018

ping @austinorr is this an issue for you?

@austinorr
Copy link

@phobson no sir, not an issue. Never look back. Also, thanks for asking :)

@jklymak jklymak merged commit 256e49e into matplotlib:master Sep 6, 2018
@anntzer anntzer deleted the py2exe branch September 6, 2018 21:33
@anntzer anntzer mentioned this pull request Jan 3, 2019
Closed
@MyreMylar MyreMylar mentioned this pull request Nov 12, 2019
Closed
@GalacticEmperor1 GalacticEmperor1 mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @phobson @austinorr @jklymak @timhoffm
0