8000 Interactive tests update by anntzer · Pull Request #12036 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Interactive tests update #12036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2018
Merged

Interactive tests update #12036

merged 3 commits into from
Sep 7, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 6, 2018

PR Summary

  • Fix typo that prevented test of qt5cairo from running.
  • wx+osx works again (at least on travis).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer
anntzer commented Sep 6, 2018
View reviewed changes
lib/matplotlib/tests/test_backends_interactive.py Outdated
for deps, backend in [ # (["cairocffi", "pgi"], "gtk3agg"),
(["cairocffi", "pgi"], "gtk3cairo"),
(["PyQt5"], "qt5agg"),
(["PyQt5", "cariocffi"], "qt5cairo"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cario -> cairo
(it's in a commit of its own for clarity)

@QuLogic
Copy link
Member
QuLogic commented Sep 6, 2018

This should be backported? (At least the typo fix should be).

@anntzer
Copy link
Contributor Author
anntzer commented Sep 6, 2018

Sure. It's in a commit of its own.

@QuLogic
Copy link
Member
QuLogic commented Sep 7, 2018

Right, but I'm asking about the others.

timhoffm
timhoffm approved these changes Sep 7, 2018
View reviewed changes
lib/matplotlib/tests/test_backends_interactive.py Outdated
@@ -18,21 +18,20 @@
def _get_testable_interactive_backends():
backends = []
# gtk3agg fails on Travis, needs to be investigated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this comment next to the commented out line in the for list. Otherwise it might be overseen and it becomes unclear why gtk3agg is commented out in the list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure...

@anntzer
Copy link
Contributor Author
anntzer commented Sep 7, 2018

I think backporting everything is fine.

Uh oh!

There was an error while loading. Please reload this page.
NelleV
NelleV approved these changes Sep 7, 2018
View reviewed changes
Copy link
Member
@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anntzer !

@NelleV NelleV merged commit b8d06c4 into matplotlib:master Sep 7, 2018
@anntzer anntzer deleted the interactive-tests branch September 7, 2018 18:37
@tacaswell tacaswell added this to the v3.0 milestone Sep 7, 2018
@tacaswell

This comment has been minimized.

Sign in to view
@tacaswell
Copy link
Member

@meeseeksdev backport to v3.0.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 7, 2018
@NelleV
Backport PR matplotlib#12036: Interactive tests update
10c7cdc
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 7, 2018
Merged
anntzer added a commit that referenced this pull request Sep 7, 2018
@anntzer
Merge pull request #12063 from meeseeksmachine/auto-backport-of-pr-12…
0d4336e 
…036-on-v3.0.x

Backport PR #12036 on branch v3.0.x (Interactive tests update)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @QuLogic @tacaswell @NelleV @timhoffm
0