Improve layout of Fill Betweenx Demo #12000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Sep 2, 2018
| @@ -13,35 +14,35 @@ | |||
| x1 = np.sin(2 * np.pi * y) | |||
| x2 = 1.2 * np.sin(4 * np.pi * y) | |||
|
|
|||
| fig, [ax1, ax2, ax3] = plt.subplots(3, 1, sharex=True) | |||
| fig, [ax1, ax2, ax3] = plt.subplots(1, 3, sharey=True, figsize=(6, 6)) | |||
There was a problem hiding this comment.
Would this demo be helped by constrained_layout=True?
There was a problem hiding this comment.
Not in particular. The main issue is that the suplots were stacked vertically. This squeezes the y axis stongly so that it's hard to see what's going on. I just changed to stacking horizontally. This looks ok even without constrainedlayout. I've linked the result in the first post above.
jklymak
approved these changes
Sep 2, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 2, 2018
QuLogic
added a commit
that referenced
this pull request
Sep 3, 2018
…000-on-v2.2.3-doc Backport PR #12000 on branch v2.2.3-doc (Improve layout of Fill Betweenx Demo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The layout of the Fill Betweenx Demo is a bit cramped.
This PR fixes this by changing from a row layout to a column layout. It includes some minor text cleanup as well.
New layout