Don't use bare except statements #11995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
approved these changes
Sep 1, 2018
tacaswell
reviewed
Sep 2, 2018
| @@ -1407,7 +1407,7 @@ def _update_enter_leave(self): | |||
| try: | |||
| if last.inaxes is not None: | |||
| last.canvas.callbacks.process('axes_leave_event', last) | |||
| except: | |||
| except Exception: | |||
There was a problem hiding this comment.
Are we sure about this one given the comment below it? Raising exceptions in GUI event loops can go very wrong very quickly (aka Qt exits the process!).
There was a problem hiding this comment.
That try-except block is only there to catch exceptions from the callbacks. KeyboardInterrupt and SystemExit can happen anywhere and Qt has to cope with this somehow. I don't see why we should catch these events if they happen by chance while the canvas callbacks are processed.
There was a problem hiding this comment.
👍 That comment almost certainly dates to when anything could be raised as as exception.
|
Sorry for the after-the-fact review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We don't want to catch
KeyboardInterruptandSystemExitexceptions in these cases.https://lgtm.com/rules/6780080/