FIX: fix importing backend with non-ascii characters #11957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67530bd to
66e2eca
Compare
|
This falls under the umbrella of things that should be fixed as it is an import error that users can not work around (I don't think telling users to restrict their directory names to only ascii (particularly if the non-ascii is coming from their name as part of their username) is an acceptable 'work around'). |
|
Appveyor did not fire on this for some reason... |
timhoffm
approved these changes
Aug 28, 2018
The issue is that the lines coming out of `traceback.format_stack()` are bytes (aka python2 str). This file uses `unicode_literals` so the string literals are unicode. If any of the paths in the stack have non-ascii we get UnicodeDecode exceptions when trying to convert the byte strings to unicode with ascii. The `str` calls will have no effect on python3 and down-cast the unicode to bytes so the operations will work. A better fix would be to sort out what encoding the bytes from `format_stack` are in and convert them to unicode, but this is simpler and is unlikely to make things worse than they were. closes matplotlib#11955
66e2eca to
69b4233
Compare
|
This code is not on master branch. but added a comment just to be safe. |
jklymak
approved these changes
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the lines coming out of
traceback.format_stack()are bytes (aka python2 str). This file uses
unicode_literalssothe string literals are unicode. If any of the paths in the stack
have non-ascii we get UnicodeDecode exceptions when trying to convert
the byte strings to unicode with ascii.
The
strcalls will have no effect on python3 and down-cast theunicode to bytes so the operations will work.
A better fix would be to sort out what encoding the bytes from
format_stackare in and convert them to unicode, but this is simplerand is unlikely to make things worse than they were.
closes #11955
PR Summary
PR Checklist