Remove some remnants of Py2-handling in test_rcparams. #11874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reindent a misindented dict.
anntzer
commented
Aug 17, 2018
| @@ -332,71 +332,60 @@ def generate_validator_testcases(valid): | |||
| ), | |||
| 'fail': (('aardvark', ValueError), | |||
| ) | |||
| }, | |||
| {'validator': validate_markevery, | |||
There was a problem hiding this comment.
This part of the diff is just removing one space at the front of each line (note how the quote under 'validator' was previously not aligned with the quote under 'fail' just above).
anntzer
commented
Aug 17, 2018
| # perform such a conversion, so the same cases should raise an exception. | ||
| # | ||
| # Common cases: | ||
| ls_test = {'validator': _validate_linestyle, |
There was a problem hiding this comment.
moved this to the main list of test cases above.
jklymak
approved these changes
Aug 17, 2018
WeatherGod
approved these changes
Aug 17, 2018
|
I wonder why the coverage dropped, though? |
|
perhaps it is because the |
|
Likely. Note that that's exactly the same thing as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now
2A85
. Please check back later.
Also reindent a misindented dict.
PR Summary
PR Checklist