8000 Reuse axes_grid1's AxisDict in axisartist, instead of duplicating it. by anntzer · Pull Request #11683 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Reuse axes_grid1's AxisDict in axisartist, instead of duplicating it. #11683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2019
Merged

Reuse axes_grid1's AxisDict in axisartist, instead of duplicating it. #11683

merged 1 commit into from
Feb 10, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jul 17, 2018

Also deprecate axisartist's SimpleChainedObjects, which is only used to
implement AxisDict (again, axes_grid1 is sufficient).

(see the duplication between https://github.com/matplotlib/matplotlib/blob/master/lib/mpl_toolkits/axes_grid1/mpl_axes.py#L6 and https://github.com/matplotlib/matplotlib/blob/master/lib/mpl_toolkits/axisartist/axislines.py#L497)

Do the reuse in this direction as axisartist already imports axes_grid1
for other purposes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.1 milestone Jul 17, 2018
@anntzer
Reuse axes_grid1's AxisDict in axisartist, instead of duplicating it.
13cca31 
Also deprecate axisartist's SimpleChainedObjects, which is only used to
implement AxisDict (again, axes_grid1 is sufficient).

Do the reuse in this direction as axisartist already imports axes_grid1
for other purposes.
@anntzer anntzer force-pushed the unduplicate-axisdict branch from 0fd668f to 13cca31 Compare January 28, 2019 22:22
@jklymak
Copy link
Member
jklymak commented Feb 10, 2019

I don't see that you remove anything? Sorry if I'm being dense..

@anntzer
Copy link
Contributor Author
anntzer commented Feb 10, 2019

I'm deprecating some (duplicated) stuff in preparation for future removal.

jklymak
jklymak approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, I see now. I must have looked at too many PRs too quickly yestrday

@timhoffm timhoffm merged commit 5d56c1c into matplotlib:master Feb 10, 2019
@anntzer anntzer deleted the unduplicate-axisdict branch February 10, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @tacaswell
0