8000 Reuse axes_grid1's AxisDict in axisartist, instead of duplicating it. · matplotlib/matplotlib@13cca31 · GitHub
[go: up one dir, main page]

Skip to content

Commit 13cca31

Browse files
committed
Reuse axes_grid1's AxisDict in axisartist, instead of duplicating it.
Also deprecate axisartist's SimpleChainedObjects, which is only used to implement AxisDict (again, axes_grid1 is sufficient). Do the reuse in this direction as axisartist already imports axes_grid1 for other purposes.
1 parent 114d516 commit 13cca31

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
API deprecations
2+
````````````````
3+
4+
The following API elements are deprecated:
5+
6+
- ``mpl_toolkits.axisartist.axislines.SimpleChainedObjects``,
7+
``mpl_toolkits.Axes.AxisDict``,

lib/mpl_toolkits/axisartist/axislines.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@
3838
In addition to AxisArtist, the Axes will have *gridlines* attribute,
3939
which obviously draws grid lines. The gridlines needs to be separated
4040
from the axis as some gridlines can never pass any axis.
41-
4241
"""
42+
4343
import numpy as np
4444

45-
from matplotlib import cbook
46-
from matplotlib import rcParams
45+
from matplotlib import cbook, rcParams
4746
import matplotlib.artist as martist
4847
import matplotlib.axes as maxes
4948
from matplotlib.path import Path
49+
from mpl_toolkits.axes_grid1 import mpl_axes
5050
from .axisline_style import AxislineStyle
5151
from .axis_artist import AxisArtist, GridlinesCollection
5252

@@ -487,6 +487,7 @@ def get_gridlines(self, which="major", axis="both"):
487487
return gridlines
488488

489489

490+
@cbook.deprecated("3.1")
490491
class SimpleChainedObjects(object):
491492
def __init__(self, objects):
492493
self._objects = objects
@@ -502,6 +503,7 @@ def __call__(self, *kl, **kwargs):
502503

503504
class Axes(maxes.Axes):
504505

506+
@cbook.deprecated("3.1")
505507
class AxisDict(dict):
506508
def __init__(self, axes):
507509
self.axes = axes
@@ -549,7 +551,7 @@ def _init_axis_artists(self, axes=None):
549551
if axes is None:
550552
axes = self
551553

552-
self._axislines = self.AxisDict(self)
554+
self._axislines = mpl_axes.Axes.AxisDict(self)
553555
new_fixed_axis = self.get_grid_helper().new_fixed_axis
554556
for loc in ["bottom", "top", "left", "right"]:
555557
self._axislines[loc] = new_fixed_axis(loc=loc, axes=axes,

0 commit comments

Comments
 (0)
0