8000 Fix the display of negative radian values in `basic_units.py` by Harnesser · Pull Request #11532 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content
Dismiss alert

Fix the display of negative radian values in basic_units.py #11532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2018
Merged

Fix the display of negative radian values in basic_units.py #11532

merged 1 commit into from
Jun 29, 2018

Conversation

Harnesser
Copy link
Contributor

PR Summary

Fix for #11531 to display negative radian values properly in basic_units.py

PR Checklist

Dunno if all of this is applicable - it's an example update?

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v2.2-doc milestone Jun 28, 2018
@Harnesser Harnesser mentioned this pull request Jun 28, 2018
Closed
tacaswell
tacaswell approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I like this method of generating the labels (due to the rounding going on) in general, but fixes it for negative values.

@tacaswell
Copy link
Member

Thanks @Harnesser !

@Harnesser
Copy link
Contributor Author

Thanks @tacaswell - for this, and for all your work on matplotlib!

@dstansby dstansby merged commit 160d9f5 into matplotlib:master Jun 29, 2018
lumberbot-app bot pushed a commit that referenced this pull request Jun 29, 2018
@dstansby
Backport PR #11532: Fix the display of negative radian values in `bas…
40311a3 
…ic_units.py`
@lumberbot-app lumberbot-app bot mentioned this pull request Jun 29, 2018
Merged
dstansby added a commit that referenced this pull request Jul 4, 2018
@dstansby
Merge pull request #11536 from matplotlib/auto-backport-of-pr-11532-o…
7f4a8d4 
…n-v2.2.2-doc

Backport PR #11532 on branch v2.2.2-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2-doc
Development

Successfully merging this pull request may close these issues.
3 participants
@Harnesser @tacaswell @dstansby
0