8000 Undefined name: cbook --> matplotlib.cbook by cclauss · Pull Request #11301 · matplotlib/matplotlib · GitHub 8000
[go: up one dir, main page]
Skip to content

Undefined name: cbook --> matplotlib.cbook #11301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anntzer merged 1 commit into from
May 24, 2018
Merged

Undefined name: cbook --> matplotlib.cbook #11301

anntzer merged 1 commit into from
May 24, 2018

Conversation

@cclauss
Copy link
@cclauss cclauss commented May 24, 2018

Use the fully qualified name because matplotlib is currently imported but matplotlib.cbook is not.

flake8 testing of https://github.com/matplotlib/matplotlib on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./lib/matplotlib/sphinxext/plot_directive.py:341:5: F821 undefined name 'cbook'
    cbook.warn_deprecated('3.0', name='remove_coding', removal='3.1')
    ^
1     F821 undefined name 'cbook'
1

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label May 24, 2018
@anntzer anntzer added this to the v3.0 milestone May 24, 2018
@anntzer
Copy link
Contributor
anntzer commented May 24, 2018

Can you instead use the following patch, which is the standard deprecation form:

@@ -164,7 +164,7 @@ except UserWarning:
     plt.switch_backend("Agg")
 else:
     import matplotlib.pyplot as plt
-from matplotlib import _pylab_helpers
+from matplotlib import _pylab_helpers, cbook
 
 __version__ = 2
 
@@ -334,11 +334,11 @@ def split_code_at_show(text):
     return parts
 
 
+@cbook.deprecated('3.0')
 def remove_coding(text):
     r"""
     Remove the coding comment, which six.exec\_ doesn't like.
     """
-    cbook.warn_deprecated('3.0', name='remove_coding', removal='3.1')
     sub_re = re.compile("^#\s*-\*-\s*coding:\s*.*-\*-$", flags=re.MULTILINE)
     return sub_re.sub("", text)

Thanks.

Undefined name: cbook --> matplotlib.cbook
7867676 
Use the _fully qualified name_ because __matplotlib__ is currently imported but __matplotlib.cbook__ is not.

flake8 testing of https://github.com/matplotlib/matplotlib on Python 3.6.3

$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__
```
./lib/matplotlib/sphinxext/plot_directive.py:341:5: F821 undefined name 'cbook'
    cbook.warn_deprecated('3.0', name='remove_coding', removal='3.1')
    ^
1     F821 undefined name 'cbook'
1
```
timhoffm
timhoffm approved these changes May 24, 2018
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anntzer are you ok to leave the depreaction as is?

@anntzer
Copy link
Contributor
anntzer commented May 24, 2018

Sure.

@anntzer anntzer merged commit ca6628b into matplotlib:master May 24, 2018
@cclauss cclauss deleted the patch-2 branch May 24, 2018 21:08
@anntzer anntzer mentioned this pull request Jun 10, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @anntzer @timhoffm
0