8000 Simplify FreeType build. by anntzer · Pull Request #11249 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Simplify FreeType build. #11249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2018
Merged

Simplify FreeType build. #11249

merged 1 commit into from
May 17, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 15, 2018

attn @timhoffm: breaking #11235 into smaller pieces.

  • Reformat a bunch of strings.
  • Rely on Python's tarfile module to extract the FreeType tarball,
    instead of the "tar" executable (because we need to use Python's
    tarfile on Windows anyways, so we may as well do it on all OSes).
  • For the Unix build, call ./configure and make without
    shell=True, instead setting CFLAGS in the environment as needed.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Simplify FreeType build.
cf84076 
- Reformat a bunch of strings.
- Rely on Python's tarfile module to extract the FreeType tarball,
  instead of the "tar" executable (because we need to use Python's
  tarfile on Windows anyways, so we may as well do it on all OSes).
- For the Unix build, call `./configure` and `make` without
  `shell=True`, instead setting CFLAGS in the environment as needed.
@anntzer anntzer force-pushed the freetype-tarball branch from 98a0e36 to cf84076 Compare May 15, 2018 06:57
timhoffm
timhoffm approved these changes May 15, 2018
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer to review! 😄

@jklymak
Copy link
Member
jklymak commented May 17, 2018

Hard to see how the Appveyor test failure is related...

@jklymak jklymak merged commit 6017a93 into matplotlib:master May 17, 2018
@anntzer anntzer deleted the freetype-tarball branch May 17, 2018 16:52
@QuLogic QuLogic added this to the v3.0 milestone May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @QuLogic
0