8000 ENH add rcparam to legend_title by jklymak · Pull Request #11172 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

ENH add rcparam to legend_title #11172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2018
Merged

ENH add rcparam to legend_title #11172

merged 1 commit into from
May 13, 2018

Conversation

jklymak
Copy link
Member
@jklymak jklymak commented May 4, 2018 •
edited
Loading

PR Summary

Adds a rcParam for legend.title_fontsize as in #10715

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@ImportanceOfBeingErnest
Copy link
Member

For the record: This Fixes #9201 and superseeds #10121.

@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request May 6, 2018
Closed
6 tasks
dstansby
dstansby reviewed May 6, 2018
View reviewed changes
lib/matplotlib/rcsetup.py
@@ -420,6 +420,13 @@ def validate_aspect(s):
raise ValueError('not a valid aspect specification')

8000
def validate_fontsize_None(s):
if s is None or s == 'None':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should s == 'none' be acceptable too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied float_or_None; I think this is here because when you type "None" in the matplotlibrc it comes back as a string. So I'd argue that should be "None" and not allow "none".

@jklymak jklymak added this to the v3.0 milestone May 10, 2018
@anntzer
Copy link
Contributor
anntzer commented May 13, 2018

thanks

@anntzer anntzer merged commit d7bd340 into matplotlib:master May 13, 2018
@hershen hershen mentioned this pull request Sep 2, 2018
Closed
@MaozGelbart MaozGelbart mentioned this pull request Mar 5, 2020
Merged
6 tasks
@MaozGelbart MaozGelbart mentioned this pull request Apr 15, 2020
Merged
@jklymak jklymak deleted the enh-rc-legend-title-fontsize6 branch January 8, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby left review comments

@timhoffm timhoffm timhoffm approved these changes

@Raab70 Raab70 Raab70 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jklymak @ImportanceOfBeingErnest @anntzer @timhoffm @dstansby @Raab70
0