Changed tight_layout doc strings #11061
Conversation
lib/matplotlib/figure.py
Outdated
| Defaults to `pad_inches`. | ||
|
|
||
| Padding between the figure edge and the edges of subplots, | ||
| as a fraction of the font size. |
There was a problem hiding this comment.
which fontsize? Otherwise, looks good....
There was a problem hiding this comment.
Here is the actual code
font_size_inches = (
FontProperties(size=rcParams["font.size"]).get_size_in_points() / 72)
But that part has been in the doc string the "whole" time. The part I changed is both difficult to understand and actually wrong.
|
There's a couple of PEP8 errors; I think you need to get rid of trailing spaces at the end of the lines added. Otherwise looks good! https://travis-ci.org/matplotlib/matplotlib/jobs/367305794#L2427 |
|
|
||
| Padding between the figure edge and the edges of subplots, | ||
| as a fraction of the font size. | ||
| h_pad, w_pad : float |
There was a problem hiding this comment.
Should stay "optional". Instead, please add "optional" to the pyplot docstring.
2c4eb8c to
5fb99d6
Compare
|
Can you please rebase on the current master. It contains fixes for the CircleCI builds, which were broken by the release of pip 10. If you need a desciption for rebaseing see here. |
5fb99d6 to
2545117
Compare
|
Thanks a lot @fredrik-1 ! |
I didn't understand what pad_inches in the
h_pad,w_paddefault was so I copied part of the doc string fromauto_adjust_subplotparsintight_layoutwhere the default was correctly explained.