E52C Py3fy testing machinery. by anntzer · Pull Request #10903 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Py3fy testing machinery. #10903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2018
Merged

Py3fy testing machinery. #10903

merged 1 commit into from
Mar 28, 2018

Conversation

@anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 28, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Py3k label Mar 28, 2018
@anntzer anntzer added this to the v3.0 milestone Mar 28, 2018
@anntzer anntzer force-pushed the py3testing branch 4 times, most recently from 0a78dc5 to 33f211b Compare March 28, 2018 00:19
timhoffm
timhoffm reviewed Mar 28, 2018
View reviewed changes
lib/matplotlib/testing/decorators.py Outdated
script_name = sys.argv[0]
basedir = os.path.abspath(os.path.dirname(script_name))
subdir = os.path.splitext(os.path.split(script_name)[1])[0]
func_path = Path(sys.argv[0]).resolve()
Copy link
Member
@timhoffm timhoffm Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module_path instead of func_path?

Copy link
Contributor Author
@anntzer anntzer Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

timhoffm
timhoffm approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally on CI pass.

@jklymak jklymak merged commit 0043d9a into matplotlib:master Mar 28, 2018
@anntzer anntzer deleted the py3testing branch March 28, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @jklymak @timhoffm
0