External transform api #1090
Merged
External transform api #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be useful for basemap? @jswhit, this PR might be of interest to you. |
| @@ -233,6 +234,8 @@ def get_transform(self): | |||
| """ | |||
| if self._transform is None: | |||
| self._transform = IdentityTransform() | |||
| elif not isinstance(self._transform, Transform) and hasattr(self._transform, '_as_mpl_transform'): | |||
There was a problem hiding this comment.
As per PEP8, please keep lines under 80 chars long.
|
Seems like there isn't much complaint about this PR. Anyone willing to merge? |
|
On 2012/08/19 9:34 PM, Phil Elson wrote:
|
| @@ -3,7 +3,8 @@ | |||
| import matplotlib | |||
| import matplotlib.cbook as cbook | |||
| from matplotlib import docstring, rcParams | |||
| from transforms import Bbox, IdentityTransform, TransformedBbox, TransformedPath | |||
| from transforms import Bbox, IdentityTransform, TransformedBbox, \ | |||
There was a problem hiding this comment.
For later cleanup, at leisure: use parentheses instead of backslash; I'm pretty sure this is supported for 2.6 and later.
| @@ -223,7 +224,7 @@ def set_transform(self, t): | |||
| ACCEPTS: :class:`~matplotlib.transforms.Transform` instance | |||
| """ | |||
| self._transform = t | |||
| self._transformSet = True | |||
| self._transformSet = t is not None | |||
There was a problem hiding this comment.
Turns out this is bad. Reverted in #1176 (along with a suitable test).
This was referenced Sep 17, 2012
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an easy interface for matplotlib transform creation based on a custom object.
The syntax looks like:
This interface is comprable to the
_as_mpl_axesmethod to easily create axes from custom classes.My primary usecase for both of these cases is to provide an interface which could do something like: