DOC: CL make pcolormesh calls consistent #10849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Mar 20, 2018
dopplershift
approved these changes
Mar 20, 2018
QuLogic
added a commit
that referenced
this pull request
Mar 21, 2018
Backport PR #10849 on branch v2.2.2-doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As per discussion in #3644 (comment) with @efiring the constrained layout guide didn't constrain ScalarMappables in different subplots to have the same
normwhen sharing a colorbar, which was deemed bad form. This fixes that in the most compact way I could think of. I added a note so its not too mysterious to users (I hope).I'm not 100% convinced this is really a problem. Like if someone shares a colorbar and sets the vmin and vmax in one axes to be inconsistent w/ the colorbar values, I'd hope they notice, but I suppose this is good practice and we should strive to show best pratices in the tutorials.
PR Checklist