Added descriptions for line bars and markers examples #10796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
requested changes
Mar 15, 2018
| """ | ||
| import matplotlib.pyplot as plt | ||
| from matplotlib import pyplot as plt |
There was a problem hiding this comment.
Why did you change this? The previous way is the way its done almost everywhere in the codebase.
| @@ -3,8 +3,11 @@ | |||
| Scatter Symbol | |||
| ============== | |||
|
|
|||
| Scatter plot with symbols. | |||
| In this example clovers are used. | |||
There was a problem hiding this comment.
Combine to "Scatter plot with clover symbols"
| @@ -3,6 +3,8 @@ | |||
| Scatter Masked | |||
| ============== | |||
|
|
|||
| Add mask line in plot. | |||
There was a problem hiding this comment.
Too enigmatic: "mask some data points, and add a line demarking masked regions"
| @@ -3,6 +3,9 @@ | |||
| Scatter Hist | |||
| ============ | |||
|
|
|||
| Creates histogram from scatter plot. | |||
| And adds them to the sides of the plot. | |||
There was a problem hiding this comment.
remove first period and capitalization.
| @@ -3,6 +3,9 @@ | |||
| Scatter Custom Symbol | |||
| ===================== | |||
|
|
|||
| Custom symbol in scatter plot. | |||
| This example is creating an ellipse | |||
There was a problem hiding this comment.
Creating a custom ellipse symbol in scatter plot.
jklymak
approved these changes
Mar 15, 2018
timhoffm
approved these changes
Mar 16, 2018
| @@ -3,7 +3,8 @@ | |||
| Scatter Masked | |||
| ============== | |||
|
|
|||
| Add mask line in plot. | |||
| Mask some data points and add a line demarking | |||
| masked regions. | |||
There was a problem hiding this comment.
This is short enough to fit on a single line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the
3055
pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
From issue #8921
Added some descriptions for the following:
examples/lines_bars_and_markers/scatter_custom_symbol.py
examples/lines_bars_and_markers/scatter_hist.py
examples/lines_bars_and_markers/scatter_masked.py
examples/lines_bars_and_markers/scatter_star_poly.py
examples/lines_bars_and_markers/scatter_symbol.py
PR Checklist