8000 wx_compat is no more. by anntzer · Pull Request #10778 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

wx_compat is no more. #10778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2018
Merged

wx_compat is no more. #10778

merged 2 commits into from
Mar 20, 2018

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Mar 14, 2018

PR Summary

wxpython4 is required for python3 support, so wx_compat can be removed, hem, deprecated.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Py3k label Mar 14, 2018
@anntzer anntzer added this to the v3.0 milestone Mar 14, 2018
jenshnielsen
jenshnielsen approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member
@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about changes to animation that seems to not belong otherwise 👍

lib/matplotlib/animation.py Outdated
@@ -383,8 +383,7 @@ def grab_frame(self, **savefig_kwargs):
dpi=self.dpi, **savefig_kwargs)
except (RuntimeError, IOError) as e:
out, err = self._proc.communicate()
_log.info('MovieWriter -- Error '
'running proc:\n%s\n%s' % (out, err))
_log.info('MovieWriter -- Error running proc:\n%s\n%s', out, err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not seem to belong in this pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to undo that; reverted that part.

@DietmarSchwertberger DietmarSchwertberger self-requested a review March 20, 2018 17:07
@DietmarSchwertberger DietmarSchwertberger merged commit 8d54d60 into matplotlib:master Mar 20, 2018
@anntzer anntzer deleted the wxcnomore branch March 20, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

@DietmarSchwertberger DietmarSchwertberger DietmarSchwertberger approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jenshnielsen @DietmarSchwertberger
0